[NPUW] Fix LLMInferRequest to work with the input prompt of len 1 #32267
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
category: NPU
smirnov-alexey
approved these changes
Oct 1, 2025
dmatveev
reviewed
Oct 1, 2025
Comment on lines
545
to
-638
| uint32_t num_embeds_dim = 1 - batch_dim; | ||
| if (shape[num_embeds_dim] > max_generation_token_len) { |
There was a problem hiding this comment.
somehow I overlooked it in the past but what is batch_dim? can this 1 - x underflow to some hugely positive value here?
There was a problem hiding this comment.
No, because batch dim is either 0 or 1 (for chat-glm), but great catch!! Let me add assert!
AsyaPronina
force-pushed
the
npuw_one_token_prompt_fix
branch
from
69cb08a to
74744ef
Compare
AsyaPronina
changed the title
Merged
via the queue into
openvinotoolkit:master
with commit Oct 10, 2025
a02f8c4
211 of 213 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details:
Tickets: